https://codereview.chromium.org/1254623002/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1254623002/diff/20001/src/heap/heap.cc#newcode3916
src/heap/heap.cc:3916: int size = FixedTypedArrayBase::kHeaderSize;
On 2015/07/27 at 08:40:05, Hannes Payer wrote:
On 2015/07/24 16:04:36, jochen wrote:
> On 2015/07/24 at 13:40:59, Hannes Payer wrote:
> > Can we have a kSize?
>
> that's misleading, because a fixed array can be on heap at which
point the size
> depends on it's length
Both sides are misleading. I do not have a strong preference.
I'll keep kHeaderSize then :)
https://codereview.chromium.org/1254623002/diff/20001/src/heap/heap.cc#newcode3924
src/heap/heap.cc:3924:
result->set_map(MapForFixedTypedArray(array_type));
On 2015/07/27 at 08:40:05, Hannes Payer wrote:
On 2015/07/24 16:04:36, jochen wrote:
> On 2015/07/24 at 13:40:59, Hannes Payer wrote:
> > Why not set_map_no_write_barrier?
>
> copied from AllocateFixedTypedArray below
This is part of the roots_ array. No need for a write barrier.
fixed both
https://codereview.chromium.org/1254623002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
