lgtm
https://codereview.chromium.org/1254623002/diff/60001/test/cctest/compiler/test-run-properties.cc
File test/cctest/compiler/test-run-properties.cc (right):
https://codereview.chromium.org/1254623002/diff/60001/test/cctest/compiler/test-run-properties.cc#newcode25
test/cctest/compiler/test-run-properties.cc:25: // elements kind to get
coverage for both access patterns:
The colon does not really make sense and it is not clear what 'both'
means here.
https://codereview.chromium.org/1254623002/diff/60001/test/cctest/compiler/test-run-properties.cc#newcode88
test/cctest/compiler/test-run-properties.cc:88: // -
IsExternalArrayElementsKind(y)
Same here.
https://codereview.chromium.org/1254623002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
