LGTM with bunch of nits.
https://codereview.chromium.org/1254623002/diff/60001/src/compiler/access-builder.cc
File src/compiler/access-builder.cc (right):
https://codereview.chromium.org/1254623002/diff/60001/src/compiler/access-builder.cc#newcode84
src/compiler/access-builder.cc:84: FieldAccess
AccessBuilder::ForExternalArrayPointer() {
Nit: Please remove this method; it is unused anyway, and misleading.
https://codereview.chromium.org/1254623002/diff/60001/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/1254623002/diff/60001/src/factory.cc#newcode886
src/factory.cc:886: Handle<FixedTypedArrayBase>
Factory::NewExternalArray(
Nit: Can we rename this method to NewFixedTypedArray
(WithExternalPointer) ?
https://codereview.chromium.org/1254623002/diff/60001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1254623002/diff/60001/src/heap/heap.cc#newcode3948
src/heap/heap.cc:3948: AllocationResult Heap::AllocateExternalArray(int
length,
Nit: Same here, rename to AllocateFixedTypedArray ?
https://codereview.chromium.org/1254623002/diff/60001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/1254623002/diff/60001/src/hydrogen-instructions.h#newcode7138
src/hydrogen-instructions.h:7138: return
IsFixedTypedArrayElementsKind(kind) ? Representation::Integer32()
How about rewriting to:
if (IsFixedTypedArrayElementsKind(kind)) {
return Representation::Integer32();
}
return Representation::Tagged();
https://codereview.chromium.org/1254623002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
