https://codereview.chromium.org/988893003/diff/260001/include/v8-tracing.h
File include/v8-tracing.h (right):
https://codereview.chromium.org/988893003/diff/260001/include/v8-tracing.h#newcode49
include/v8-tracing.h:49: virtual EventTracer::Handle AddTraceEvent(
I'm very positive about the CL in general, but rather than introducing
additional class for embedders to implement, can we just add these to
v8::Platform? Besides simplifying the API slightly, there's another
small advantage in that docs already stress well the need for
InitializePlatform to be called before v8 initialization, which I think
is critical in case of tracing (due to caching of category pointers).
https://codereview.chromium.org/988893003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
