On 2015/09/08 at 17:57:49, caseq wrote:
https://codereview.chromium.org/988893003/diff/260001/include/v8-tracing.h
File include/v8-tracing.h (right):
https://codereview.chromium.org/988893003/diff/260001/include/v8-tracing.h#newcode49
include/v8-tracing.h:49: virtual EventTracer::Handle AddTraceEvent(
On 2015/09/08 14:20:34, jochen wrote:
> we shouldn't have a global static event tracer, but it should be scoped
to
an
> isolate (eventually, the v8::Platform will also be passed to
Isolate::New)
Current trace macros implementation relies on static variables for caching
pointers to category enable flags (see
https://code.google.com/p/chromium/codesearch#chromium/src/base/trace_event/trace_event.h&l=203)
-- so I'm afraid that allowing setting tracers per isolate may create a
false
impression that one could use different tracer implementation for different
isolates, while we actually rely on tracer being a singleton.
I'm not saying that chromium's tracing shouldn't use static variables, but
v8
should definitely not add new ones.
https://codereview.chromium.org/988893003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
