not sure why this would be a larger fix? it would require moving the files
in
chromium (large CL but automated), filing an infra ticket, and replacing the
files in the CLs with a DEPS entry.
some comments inline.
what's the plan with all the new trace macros? will they supersede the LOG()
macros currently used in v8? if yes, who's going to do that?
https://codereview.chromium.org/988893003/diff/260001/include/v8-tracing.h
File include/v8-tracing.h (right):
https://codereview.chromium.org/988893003/diff/260001/include/v8-tracing.h#newcode49
include/v8-tracing.h:49: virtual EventTracer::Handle AddTraceEvent(
agreed.
Either it should be part of the platform, or passed via the
Isolate::CreateParams.
we shouldn't have a global static event tracer, but it should be scoped
to an isolate (eventually, the v8::Platform will also be passed to
Isolate::New)
https://codereview.chromium.org/988893003/diff/260001/src/tracing/trace-event.h
File src/tracing/trace-event.h (right):
https://codereview.chromium.org/988893003/diff/260001/src/tracing/trace-event.h#newcode238
src/tracing/trace-event.h:238: (uint64_t)
v8::internal::Isolate::UnsafeCurrent
don't use this method.
Isolate* should be always passed around explicitly, you can't rely on
getting the Isolate via any of the *Current() methods
https://codereview.chromium.org/988893003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
