LGTM

I'm not sure about the limit though.  It will be random whether a new space
string is allocated before that limit or after it. We already talked about this
offline, but wouldn't it be better to never externalize new space strings?


http://codereview.chromium.org/608006/diff/1/2
File src/api.cc (right):

http://codereview.chromium.org/608006/diff/1/2#newcode3135
src/api.cc:3135: // Determines whether a string is fresh, that is
whether it's
Determines -> Estimates (based on how close it is to the new space top).

http://codereview.chromium.org/608006

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to