On 2010/02/15 13:31:26, Mads Ager wrote:
LGTM
I'm not sure about the limit though. It will be random whether a new
space
string is allocated before that limit or after it. We already talked
about
this
offline, but wouldn't it be better to never externalize new space strings?
Never externalizing new space strings would be a cleaner but more dangerous
approach. The problem with it is that the embedder can potentially convert a
large new space string many times, and so not externalizing it will make
things
worse. The freshness limit is also a string length limit and will help to
avoid
such problems.
http://codereview.chromium.org/608006/diff/1/2
File src/api.cc (right):
http://codereview.chromium.org/608006/diff/1/2#newcode3135
src/api.cc:3135: // Determines whether a string is fresh, that is whether
it's
Determines -> Estimates (based on how close it is to the new space top).
Done.
http://codereview.chromium.org/608006
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
