Thanks! Submitted.
-- Vitaly http://codereview.chromium.org/608006/diff/7001/7002 File src/api.cc (right): http://codereview.chromium.org/608006/diff/7001/7002#newcode2467 src/api.cc:2467: // Records that the given string's characters were copied to some On 2010/02/16 08:16:19, Mads Ager wrote:
Could you update the comments in this class to make it clear that you
do not
have a counter per string?
Done. http://codereview.chromium.org/608006/diff/7001/7003 File test/cctest/test-api.cc (right): http://codereview.chromium.org/608006/diff/7001/7003#newcode474 test/cctest/test-api.cc:474: CHECK(small_string->CanMakeExternal()); On 2010/02/16 08:16:19, Mads Ager wrote:
small_ -> large_
Oops. Done. http://codereview.chromium.org/608006/diff/7001/7003#newcode511 test/cctest/test-api.cc:511: CHECK(small_string->CanMakeExternal()); On 2010/02/16 08:16:19, Mads Ager wrote:
small_ -> large_
Ditto. http://codereview.chromium.org/608006 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
