http://codereview.chromium.org/604059/diff/4001/4003 File src/builtins.cc (right):
http://codereview.chromium.org/604059/diff/4001/4003#newcode431 src/builtins.cc:431: if (fast_slice == JSFunction::cast(table->get(index + 2))->code()) { This seems like a hack. Why not just lookup the function on the builtins object? Top::global_context()->builtins()->GetProperty("..."); http://codereview.chromium.org/604059/diff/4001/4003#newcode486 src/builtins.cc:486: // Step 6. Do these steps refer to steps in the spec? If they do, please make a complete reference: ECMAScript 262, 3rd Edition, Section ..., step 6. http://codereview.chromium.org/604059/diff/4001/4003#newcode499 src/builtins.cc:499: Object* result = 0; Just declare it below: Object* result = Heap::Allocate... http://codereview.chromium.org/604059 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
