Thanks a lot for comments, Mads.
Here go/lem:
http://compute3.aar:9013/golem/r3859-v8-antonm-array-slice-vs-3859-v8.html
http://codereview.chromium.org/604059/diff/4001/4003
File src/builtins.cc (right):
http://codereview.chromium.org/604059/diff/4001/4003#newcode431
src/builtins.cc:431: if (fast_slice == JSFunction::cast(table->get(index
+ 2))->code()) {
On 2010/02/16 09:03:03, Mads Ager wrote:
This seems like a hack. Why not just lookup the function on the
builtins
object?
Top::global_context()->builtins()->GetProperty("...");
I thought it could be faster and more obvious that we call shadowed
version. Anyway done.
http://codereview.chromium.org/604059/diff/4001/4003#newcode486
src/builtins.cc:486: // Step 6.
On 2010/02/16 09:03:03, Mads Ager wrote:
Do these steps refer to steps in the spec? If they do, please make a
complete
reference: ECMAScript 262, 3rd Edition, Section ..., step 6.
Done. Could easily remove them if you don't think they add any value.
http://codereview.chromium.org/604059/diff/4001/4003#newcode499
src/builtins.cc:499: Object* result = 0;
On 2010/02/16 09:03:03, Mads Ager wrote:
Just declare it below: Object* result = Heap::Allocate...
Done.
http://codereview.chromium.org/604059
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
