Thanks a lot, Mads. Submitting.
http://codereview.chromium.org/604059/diff/3002/3004 File src/builtins.cc (right): http://codereview.chromium.org/604059/diff/3002/3004#newcode427 src/builtins.cc:427: Object* r = Heap::LookupAsciiSymbol("ArraySlice"); On 2010/02/16 11:32:12, Mads Ager wrote:
Since you are using handles here already, you should use Factory::LookupAsciiSymbol and avoid the failure check.
Done. And I switched to GetProperty from handles. http://codereview.chromium.org/604059/diff/3002/3008 File test/mjsunit/array-slice.js (right): http://codereview.chromium.org/604059/diff/3002/3008#newcode28 test/mjsunit/array-slice.js:28: // Check that shifting array of holes keeps it as array of holes On 2010/02/16 11:32:12, Mads Ager wrote:
shifting -> slicing
Thanks a lot, done. http://codereview.chromium.org/604059 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
