Comment #8 on issue 4382 by [email protected]: make always regenerates
snapshot
https://code.google.com/p/v8/issues/detail?id=4382#c8
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/244cc0a6a9643bee962c2e3c60a1e093f18fe9ed
commit 244cc0a6a9643bee962c2e3c60a1e093f18fe9ed
Author: vogelheim <[email protected]>
Date: Tue Sep 08 15:24:45 2015
Remove all gyp BUILD rules with multiple outputs.
- Modify js2c to accept --js and --nojs,
- modify mksnapshot to accept --startup_src
(instead of a positional parameter, so that it can be omitted),
- modify v8.gyp to use the above so that no target has multiple
output dependencies, and
- update GN to use the switches above.
(I have not succeeded in fixing the GYP->make translator to properly map
multi-output rules, so that they work as expected in all edge cases.
This CL signals defeat on that front, and instead I rewrite the GYP
file to avoid that situation in the first place.)
[email protected]
BUG=v8:4382
LOG=N
Review URL: https://codereview.chromium.org/1310273009
Cr-Commit-Position: refs/heads/master@{#30640}
[modify] http://crrev.com/244cc0a6a9643bee962c2e3c60a1e093f18fe9ed/BUILD.gn
[modify]
http://crrev.com/244cc0a6a9643bee962c2e3c60a1e093f18fe9ed/src/flag-definitions.h
[modify]
http://crrev.com/244cc0a6a9643bee962c2e3c60a1e093f18fe9ed/src/snapshot/mksnapshot.cc
[modify]
http://crrev.com/244cc0a6a9643bee962c2e3c60a1e093f18fe9ed/tools/gyp/v8.gyp
[modify]
http://crrev.com/244cc0a6a9643bee962c2e3c60a1e093f18fe9ed/tools/js2c.py
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
