LGTM, I wonder if we should make a new function traversing the prototype
once
looking for all of the names?
http://codereview.chromium.org/619006/diff/1/5
File src/objects.cc (right):
http://codereview.chromium.org/619006/diff/1/5#newcode4844
src/objects.cc:4844: name, &result, true);
Will this formatting overflow?
JSObject::cast(prototype)->LookupCallbackSetterInPrototypes(name,
&result,
true);
What is the limit on the number of simple assignments for which we
generate constructors. This ends up traversing the whole prototype
chain for each name. But maybe that isn't a problem.
http://codereview.chromium.org/619006/diff/1/7
File src/objects.h (right):
http://codereview.chromium.org/619006/diff/1/7#newcode1374
src/objects.h:1374: void LookupCallbackSetterInPrototypes(String* name,
I guess this should just be called LookupCallbackSetter now. Can we
make the bool argument an enum with values INCLUDE_THIS and
DONT_INCLUDE_THIS and remove the default arg?
http://codereview.chromium.org/619006/diff/1/2
File test/cctest/test-api.cc (right):
http://codereview.chromium.org/619006/diff/1/2#newcode9634
test/cctest/test-api.cc:9634: ""
Remove empty lines?
http://codereview.chromium.org/619006/diff/1/2#newcode9686
test/cctest/test-api.cc:9686: ""
Remove?
http://codereview.chromium.org/619006
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
