[v8-dev] Re: Refactor the check for generating inline constructors... (issue619006)

[sgjesse]

Sorry for the mess, fixed in r3894 (http://codereview.chromium.org/647007)


http://codereview.chromium.org/619006/diff/6001/6005
File src/objects.cc (right):

http://codereview.chromium.org/619006/diff/6001/6005#newcode4838
src/objects.cc:4838: // the same names as are set by the inline
constructor..
On 2010/02/18 09:19:35, Mads Ager wrote:

.. -> .

http://codereview.chromium.org/647007

http://codereview.chromium.org/619006/diff/6001/6002
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/619006/diff/6001/6002#newcode9634
test/cctest/test-api.cc:9634: ""
On 2010/02/18 09:19:35, Mads Ager wrote:

Remove trailing empty strings?

http://codereview.chromium.org/647007

http://codereview.chromium.org/619006/diff/6001/6002#newcode9686
test/cctest/test-api.cc:9686: ""
On 2010/02/18 09:19:35, Mads Ager wrote:

Remove trailing empty strings?

http://codereview.chromium.org/647007

http://codereview.chromium.org/619006/diff/6001/6003
File test/mjsunit/setter-on-constructor-prototype.js (right):

http://codereview.chromium.org/619006/diff/6001/6003#newcode111
test/mjsunit/setter-on-constructor-prototype.js:111: //RunTest(true);
On 2010/02/18 09:19:35, Mads Ager wrote:

Code in comment - doesn't this work?

http://codereview.chromium.org/647007 (it did work).

http://codereview.chromium.org/619006

--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev