Dropped the use of LookupCallbackSetterInPrototypes and did an explicit
traversal of the chain in CanGenerateInlineConstructor as I needed a check
for
objects on the prototype chain not being in dictionary mode for the
upcoming map
check in the inline constructor code anyway.
http://codereview.chromium.org/619006/diff/1/5
File src/objects.cc (right):
http://codereview.chromium.org/619006/diff/1/5#newcode4844
src/objects.cc:4844: name, &result, true);
On 2010/02/17 13:36:33, Mads Ager wrote:
Will this formatting overflow?
JSObject::cast(prototype)->LookupCallbackSetterInPrototypes(name,
&result,
true);
What is the limit on the number of simple assignments for which we
generate
constructors. This ends up traversing the whole prototype chain for
each name.
But maybe that isn't a problem.
Not calling LookupCallbackSetterInPrototypes here any more.
http://codereview.chromium.org/619006/diff/1/7
File src/objects.h (right):
http://codereview.chromium.org/619006/diff/1/7#newcode1374
src/objects.h:1374: void LookupCallbackSetterInPrototypes(String* name,
On 2010/02/17 13:36:33, Mads Ager wrote:
I guess this should just be called LookupCallbackSetter now. Can we
make the
bool argument an enum with values INCLUDE_THIS and DONT_INCLUDE_THIS
and remove
the default arg?
Dropped this change.
http://codereview.chromium.org/619006
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
