Looks good overall, just a couple of nits.
Jochen, do you want to give it a once over too (If you are fine with the
approach I'll not bother you with future ones).
https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopables-hidden-prototype.cc
File test/cctest/test-unscopables-hidden-prototype.cc (right):
https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopables-hidden-prototype.cc#newcode29
test/cctest/test-unscopables-hidden-prototype.cc:29:
v8::Local<v8::Context> curr_context = isolate->GetCurrentContext();
nit - please don't abbreviate - current_context.
https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopables-hidden-prototype.cc#newcode45
test/cctest/test-unscopables-hidden-prototype.cc:45:
object->SetPrototype(curr_context, hidden_prototype).FromMaybe(false);
Could you add a CHECK() around this to check the value returned is true.
https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopables-hidden-prototype.cc#newcode62
test/cctest/test-unscopables-hidden-prototype.cc:62: .FromMaybe(-1));
nit - could .FromMaybe(-1) be on the same line as ->Int32Value couldn't
it (or did git cl format do this to you)?
https://codereview.chromium.org/1331013003/diff/1/test/cctest/trace-extension.cc
File test/cctest/trace-extension.cc (right):
https://codereview.chromium.org/1331013003/diff/1/test/cctest/trace-extension.cc#newcode53
test/cctest/trace-extension.cc:53: .FromMaybe(false)) {
nit - could .FromMaybe(..) go on the same line as .ToLocalChecked() here
too?
https://codereview.chromium.org/1331013003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
