Thanks for the quick review. I addressed all the comments.
I just have one question regarding the formatting here
https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopables-hidden-prototype.cc#newcode62
Could you please quickly guide me on this
Thanks and Regards,
Mythri
https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopables-hidden-prototype.cc
File test/cctest/test-unscopables-hidden-prototype.cc (right):
https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopables-hidden-prototype.cc#newcode29
test/cctest/test-unscopables-hidden-prototype.cc:29:
v8::Local<v8::Context> curr_context = isolate->GetCurrentContext();
On 2015/09/10 09:30:16, rmcilroy wrote:
nit - please don't abbreviate - current_context.
Done.
https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopables-hidden-prototype.cc#newcode45
test/cctest/test-unscopables-hidden-prototype.cc:45:
object->SetPrototype(curr_context, hidden_prototype).FromMaybe(false);
On 2015/09/10 09:30:16, rmcilroy wrote:
Could you add a CHECK() around this to check the value returned is
true.
Done.
https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopables-hidden-prototype.cc#newcode45
test/cctest/test-unscopables-hidden-prototype.cc:45:
object->SetPrototype(curr_context, hidden_prototype).FromMaybe(false);
On 2015/09/10 09:33:24, jochen wrote:
On 2015/09/10 at 09:30:16, rmcilroy wrote:
> Could you add a CHECK() around this to check the value returned is
true.
Just use .FromJust() that checks internally.
Done.
https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopables-hidden-prototype.cc#newcode62
test/cctest/test-unscopables-hidden-prototype.cc:62: .FromMaybe(-1));
On 2015/09/10 09:33:24, jochen wrote:
On 2015/09/10 at 09:30:16, rmcilroy wrote:
> nit - could .FromMaybe(-1) be on the same line as ->Int32Value
couldn't it (or
did git cl format do this to you)?
same here... FromJust()
Done.
https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopables-hidden-prototype.cc#newcode62
test/cctest/test-unscopables-hidden-prototype.cc:62: .FromMaybe(-1));
On 2015/09/10 09:30:16, rmcilroy wrote:
nit - could .FromMaybe(-1) be on the same line as ->Int32Value
couldn't it (or
did git cl format do this to you)?
This is git cl format. I can move FromMaybe to the earlier line. Should
I also move ->Int32Vale(current_contex).FroMaybe(-1) to the earlier
line? It still fits in 80 character limit. I am not sure about
formatting guidelines for these.
https://codereview.chromium.org/1331013003/diff/1/test/cctest/trace-extension.cc
File test/cctest/trace-extension.cc (right):
https://codereview.chromium.org/1331013003/diff/1/test/cctest/trace-extension.cc#newcode53
test/cctest/trace-extension.cc:53: .FromMaybe(false)) {
On 2015/09/10 09:30:16, rmcilroy wrote:
nit - could .FromMaybe(..) go on the same line as .ToLocalChecked()
here too?
Done.
https://codereview.chromium.org/1331013003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
