overall looks good
can you please run tryjobs?
ToLocalChecked() corresponds to FromJust() which checks that the Maybe<>
value
is "just", so I'd use that where possible.
https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopables-hidden-prototype.cc
File test/cctest/test-unscopables-hidden-prototype.cc (right):
https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopables-hidden-prototype.cc#newcode45
test/cctest/test-unscopables-hidden-prototype.cc:45:
object->SetPrototype(curr_context, hidden_prototype).FromMaybe(false);
On 2015/09/10 at 09:30:16, rmcilroy wrote:
Could you add a CHECK() around this to check the value returned is
true.
Just use .FromJust() that checks internally.
https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopables-hidden-prototype.cc#newcode62
test/cctest/test-unscopables-hidden-prototype.cc:62: .FromMaybe(-1));
On 2015/09/10 at 09:30:16, rmcilroy wrote:
nit - could .FromMaybe(-1) be on the same line as ->Int32Value
couldn't it (or did git cl format do this to you)?
same here... FromJust()
https://codereview.chromium.org/1331013003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
