https://codereview.chromium.org/988893003/diff/320001/include/v8-platform.h
File include/v8-platform.h (right):
https://codereview.chromium.org/988893003/diff/320001/include/v8-platform.h#newcode125
include/v8-platform.h:125: * Add a trace event to the platform tracing
system.
On 2015/11/19 at 09:30:32, Yang wrote:
Can you add a comment about what this method returns? It seems unclear
to me.
I have updated the description on all the methods.
https://codereview.chromium.org/988893003/diff/320001/src/tracing/trace-event.h
File src/tracing/trace-event.h (right):
https://codereview.chromium.org/988893003/diff/320001/src/tracing/trace-event.h#newcode276
src/tracing/trace-event.h:276: class TraceID {
On 2015/11/19 at 09:30:32, Yang wrote:
Is this ID used to represent the isolate? If yes, then adding all the
different flavors of DontMangle and ForceMangle seems a bit overkill if
we are only going to use DontMangle(const void*).
DontMangle is used by the TRACE_EVENT_OBJECT_* macros which can be used
to "track the life time and value of arbitrary client objects."
therefore we need the full list here.
https://codereview.chromium.org/988893003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
