Hi everyone, the "Jumbo" build (multiple .cc files per compilation unit, saving lots of compile time) is running into the issue of name clashing between v8::internal::Register and v8::internal::interpreter::Register. We have a few options:
(1) Rename internal::Register to AsmRegister. Partial CL: https://chromium-review.googlesource.com/627317 <https://chromium-review.googlesource.com/c/v8/v8/+/627317> Line count: 2985 with 2 architectures done (I count ~1100 lines per arch) (2) Rename interpreter::Register to (e.g.) InterpreterRegister. (Exact name TBD.) Demo CL: https://chromium-review.googlesource.com/644182 Line count: 768 (3) Make every use of "Register" explicitly use "internal::Register" or "interpreter::Register". (4) Ignore the issue and have either no Jumbo builds, or only limited Jumbo builds, or random Jumbo build failures triggered by unrelated changes (which happen to change the compilation unit chunks). Personally, I'm inclined to favor option (2), because it's a smaller diff than (1), and both of those are more readable than (3). Possible names: InterpreterRegister, IgnitionRegister, IgnRegister, IRegister, BytecodeRegister, BcRegister, <your suggestion here> Other opinions? Cheers, Jakob -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
