On Thursday, August 31, 2017 at 11:22:15 AM UTC+2, Leszek Swirski wrote: > > Normally I wouldn't expect this to be ambiguous in our code style, where > *.cc files still wrap everything in namespaces rather than using "using > namespace foo". >
Here's an example of where I think jumbo builds could possibly introduce ambiguity in type resolution, even if all code is inside namespace blocks: Let's say a source file has some code in the v8::internal::intepreter namespace which refers to "Register" which is resolved to v8::internal::Register in non-jumbo builds because the code does not have a forward declaration or header include for v8::internal::interpreter::Register. Then in jumbo builds, a header inclusion from a preceeding source file makes v8::internal::interpreter::Register visible, and the compiler (I assume) selects this for "Register" since it has the deepest matching namespace. -Mostyn. -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
