On 08/31/2017 12:49 AM, Jakob Kummerow wrote: > the "Jumbo" build (multiple .cc files per compilation unit, saving lots of > >> compile time) is running into the issue of name clashing between > >> v8::internal::Register and v8::internal::interpreter::Register. We have a > few options:
Normally I wouldn't expect this to be ambiguous in our code style, where *.cc files still wrap everything in namespaces rather than using "using namespace foo". The one probably relevant exception I see is a "using namespace interpreter" in src/compiler/bytecode-analysis.cc <https://cs.chromium.org/chromium/src/v8/src/compiler/bytecode-analysis.cc?l=15&rcl=629b23ae58c01b3eba0f22e08f265942d2bca301>. If we were to get rid of this, perhaps it'd be enough? I'm not a big fan of the Smurf Naming Convention <https://blog.codinghorror.com/new-programming-jargon/> for already namespaced classes. -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
