Hi Sirish, If your patches pass the test suite locally then upload them on gerrit for review. If you have issues with your patch then feel free to ask question on this mailing list. Before your patch can be committed you need to sign the CLA (individual or corporate).
Cheers, Rodolph On Wed, 16 Jan 2019 at 14:05, <[email protected]> wrote: > Hi Ross, > > I think the patches were already attached. Here's it. > > Also, I will have more patches coming up. Is there a process for me to put > it on gerrit and follow up from there? At what point should I start using > git cl? > > Thanks. > Sirish > > > > On Wednesday, January 16, 2019 at 10:08:20 AM UTC-6, Ross McIlroy wrote: >> >> Hi Sirish, >> >> Thanks for your contributions. Could you link to the two patches so that >> I can make sure they have appropriate reviewers assigned? >> >> Cheers, >> Ross >> >> >> On Wed, 16 Jan 2019 at 15:53, <[email protected]> wrote: >> >>> Hi all, >>> >>> Following the directions from https://v8.dev/docs/contribute, I am >>> putting my first two patches (for review) for ARM64 that I would like to >>> contribute to V8. >>> >>> First patch is a very simple patch - it adds default march for ARM64. >>> 64-bit support in ARM started with arm version 8. >>> Second patch is a probe implementation of ARM64, and probes for crc32 >>> feature. This feature is later used, if present, in hashing algorithm. This >>> patch improves speedometer performance by about half a percent on current >>> Samsung and Pixel devices. >>> >>> Please review these patches, and let me know what I need to do next to >>> get these patches committed. >>> >>> Sirish Pande >>> Samsung Austin R&D Center >>> >>> -- >>> -- >>> v8-dev mailing list >>> [email protected] >>> http://groups.google.com/group/v8-dev >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "v8-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
