Thanks Rodolph, I tested with gm check and it tested on arm/arm64/ia32/x64 debug and release. There was one WASM error with or without my patch.
However, when I tired to presubmit my patch with (git cl presubmit), it states the following: """ cc02:v8:[master]>git cl presubmit Running presubmit commit checks ... Done processing /work/sirish.pande/v8/v8/src/base/functional.cc Total C/C++ files found that require formatting: 0 No changes in Torque files detected. Skipping check Total violating files: 0 ** Presubmit Messages ** Detected mismatches in #define / #undef in the file(s) where you modified preprocessor macros. src/base/cpu.cc:25: Macro missing #undef: POWER_8 \ src/base/cpu.cc:28: Macro missing #undef: POWER_9 \ src/base/cpu.cc:89: Macro missing #undef: HWCAP_FP \ src/base/cpu.cc:90: Macro missing #undef: HWCAP_ASIMD \ src/base/cpu.cc:91: Macro missing #undef: HWCAP_EVTSTRM \ src/base/cpu.cc:92: Macro missing #undef: HWCAP_AES \ src/base/cpu.cc:93: Macro missing #undef: HWCAP_PMULL \ src/base/cpu.cc:94: Macro missing #undef: HWCAP_SHA1 \ src/base/cpu.cc:95: Macro missing #undef: HWCAP_SHA2 \ src/base/cpu.cc:96: Macro missing #undef: HWCAP_CRC32 \ src/base/cpu.cc:97: Macro missing #undef: HWCAP_ATOMICS \ src/base/cpu.cc:98: Macro missing #undef: HWCAP_FPHP \ src/base/cpu.cc:99: Macro missing #undef: HWCAP_ASIMDHP \ src/base/cpu.cc:109: Macro missing #undef: HWCAP_SWP \ src/base/cpu.cc:110: Macro missing #undef: HWCAP_HALF \ src/base/cpu.cc:111: Macro missing #undef: HWCAP_THUMB \ src/base/cpu.cc:112: Macro missing #undef: HWCAP_26BIT \ src/base/cpu.cc:113: Macro missing #undef: HWCAP_FAST_MULT \ src/base/cpu.cc:114: Macro missing #undef: HWCAP_FPA \ src/base/cpu.cc:115: Macro missing #undef: HWCAP_VFP \ src/base/cpu.cc:116: Macro missing #undef: HWCAP_EDSP \ src/base/cpu.cc:117: Macro missing #undef: HWCAP_JAVA \ src/base/cpu.cc:118: Macro missing #undef: HWCAP_IWMMXT \ src/base/cpu.cc:119: Macro missing #undef: HWCAP_CRUNCH \ src/base/cpu.cc:120: Macro missing #undef: HWCAP_THUMBEE \ src/base/cpu.cc:121: Macro missing #undef: HWCAP_NEON \ src/base/cpu.cc:122: Macro missing #undef: HWCAP_VFPv3 \ src/base/cpu.cc:123: Macro missing #undef: HWCAP_VFPv3D16 \ src/base/cpu.cc:124: Macro missing #undef: HWCAP_TLS \ src/base/cpu.cc:125: Macro missing #undef: HWCAP_VFPv4 \ src/base/cpu.cc:126: Macro missing #undef: HWCAP_IDIVA \ src/base/cpu.cc:127: Macro missing #undef: HWCAP_IDIVT \ src/base/cpu.cc:128: Macro missing #undef: HWCAP_VFPD32 \ src/base/cpu.cc:129: Macro missing #undef: HWCAP_IDIV \ src/base/cpu.cc:130: Macro missing #undef: HWCAP_LPAE ** Presubmit ERRORS ** OWNERS check failed: this CL has no Gerrit change number, so we can't check it for approvals. [email protected] is not in AUTHORS file. If you are a new contributor, please visit https://www.chromium.org/developers/contributing-code and read the "Legal" section If you are a chromite, verify the contributor signed the CLA. You added one or more #includes that violate checkdeps rules. src/base/functional.cc Illegal include: "src/cpu-features.h" Because of "-src" from src/base's include_rules. "" Basically boils down to the following: 1. It asks me to set #undefs on piece of code, that I did not write. 2. It asks for Gerrit change number, which I don't have. 3. I have signed both Corporate and Individual aggrement. But it still complains about it. 4. There is a checkdeps failure. Can you please help in addressing these issues? Thanks. Sirish On Wednesday, January 16, 2019 at 1:19:56 PM UTC-6, Rodolph Perfetta wrote: > > Hi Sirish, > > If your patches pass the test suite locally then upload them on gerrit for > review. If you have issues with your patch then feel free to ask question > on this mailing list. Before your patch can be committed you need to sign > the CLA (individual or corporate). > > Cheers, > Rodolph > > On Wed, 16 Jan 2019 at 14:05, <[email protected] <javascript:>> wrote: > >> Hi Ross, >> >> I think the patches were already attached. Here's it. >> >> Also, I will have more patches coming up. Is there a process for me to >> put it on gerrit and follow up from there? At what point should I start >> using git cl? >> >> Thanks. >> Sirish >> >> >> >> On Wednesday, January 16, 2019 at 10:08:20 AM UTC-6, Ross McIlroy wrote: >>> >>> Hi Sirish, >>> >>> Thanks for your contributions. Could you link to the two patches so that >>> I can make sure they have appropriate reviewers assigned? >>> >>> Cheers, >>> Ross >>> >>> >>> On Wed, 16 Jan 2019 at 15:53, <[email protected]> wrote: >>> >>>> Hi all, >>>> >>>> Following the directions from https://v8.dev/docs/contribute, I am >>>> putting my first two patches (for review) for ARM64 that I would like to >>>> contribute to V8. >>>> >>>> First patch is a very simple patch - it adds default march for ARM64. >>>> 64-bit support in ARM started with arm version 8. >>>> Second patch is a probe implementation of ARM64, and probes for crc32 >>>> feature. This feature is later used, if present, in hashing algorithm. >>>> This >>>> patch improves speedometer performance by about half a percent on current >>>> Samsung and Pixel devices. >>>> >>>> Please review these patches, and let me know what I need to do next to >>>> get these patches committed. >>>> >>>> Sirish Pande >>>> Samsung Austin R&D Center >>>> >>>> -- >>>> -- >>>> v8-dev mailing list >>>> [email protected] >>>> http://groups.google.com/group/v8-dev >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "v8-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> -- >> -- >> v8-dev mailing list >> [email protected] <javascript:> >> http://groups.google.com/group/v8-dev >> --- >> You received this message because you are subscribed to the Google Groups >> "v8-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> For more options, visit https://groups.google.com/d/optout. >> > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
