I have uploaded two patches. https://chromium-review.googlesource.com/c/v8/v8/+/1423124
https://chromium-review.googlesource.com/c/v8/v8/+/142312 <https://chromium-review.googlesource.com/c/v8/v8/+/1423124>5 Please have a look. Sirish On Friday, January 18, 2019 at 4:21:27 PM UTC-6, [email protected] wrote: > > Thanks Jakob, > > I cleaned up all errors and upload the patches. > > https://chromium-review.googlesource.com/c/v8/v8/+/1423182 > > > In fact, I had two patches, it merged into one. I can create two patches > and submit one at a time. > > I will abandon the review and create two different ones. > > Sirish > > On Thursday, January 17, 2019 at 6:13:32 PM UTC-6, Jakob Kummerow wrote: >> >> I tested with gm check and it tested on arm/arm64/ia32/x64 debug and >>> release. >> >> >> Pro tip: you can save time by running only a relevant subset of >> platforms, e.g. "gm arm64.check ia32.release.check" (or other combinations; >> gm is very flexible). >> >> >>> Basically boils down to the following: >>> >> 1. It asks me to set #undefs on piece of code, that I did not write. >>> >> >> The way the presubmit checks works is that it only looks at changed >> files. Apparently nobody added macros to cpu.cc since the check was >> introduced. Just add the #undefs at the bottom of the file. >> >> >>> 2. It asks for Gerrit change number, which I don't have. >>> >> >> You can ignore that; you'll have one after uploading. >> >> >>> 3. I have signed both Corporate and Individual aggrement. But it still >>> complains about it. >>> >> >> It complains about the AUTHORS file, not the CLA. There's a blanket entry >> for *@*.samsung.com in there, but your email address is @samsung.com. >> I'm not sure how best to proceed here, that's for managers and lawyers to >> figure out. There are several options: >> - update the existing *@*.samsung.com blanket entry to read *@samsung.com >> instead >> - update the existing *@*.samsung.com blanket entry to read *@* >> samsung.com instead >> - add a new *@samsung.com blanket entry >> - add an individual entry for you (there is precedent for that, but it >> seems weird to me given the existence of the blanket entry) >> >> CC +hablich to provide input. >> >> By the way, you usually shouldn't sign the individual CLA with a >> corporate account for which also a corporate CLA entry exists, but that's >> between you and your employer to figure out. >> >> >>> 4. There is a checkdeps failure. >>> >> >> Yes, src/base/*.cc can't #include any src/*.h headers. You'll have to >> restructure something. >> >> You can run "git cl upload --bypass-hooks" to upload without presubmit >> checks. That way, you can get eyes on your change before addressing >> everything. >> >> >>> Can you please help in addressing these issues? >>> >>> Thanks. >>> Sirish >>> >>> >>> On Wednesday, January 16, 2019 at 1:19:56 PM UTC-6, Rodolph Perfetta >>> wrote: >>>> >>>> Hi Sirish, >>>> >>>> If your patches pass the test suite locally then upload them on gerrit >>>> for review. If you have issues with your patch then feel free to ask >>>> question on this mailing list. Before your patch can be committed you need >>>> to sign the CLA (individual or corporate). >>>> >>>> Cheers, >>>> Rodolph >>>> >>>> On Wed, 16 Jan 2019 at 14:05, <[email protected]> wrote: >>>> >>>>> Hi Ross, >>>>> >>>>> I think the patches were already attached. Here's it. >>>>> >>>>> Also, I will have more patches coming up. Is there a process for me to >>>>> put it on gerrit and follow up from there? At what point should I start >>>>> using git cl? >>>>> >>>>> Thanks. >>>>> Sirish >>>>> >>>>> >>>>> >>>>> On Wednesday, January 16, 2019 at 10:08:20 AM UTC-6, Ross McIlroy >>>>> wrote: >>>>>> >>>>>> Hi Sirish, >>>>>> >>>>>> Thanks for your contributions. Could you link to the two patches so >>>>>> that I can make sure they have appropriate reviewers assigned? >>>>>> >>>>>> Cheers, >>>>>> Ross >>>>>> >>>>>> >>>>>> On Wed, 16 Jan 2019 at 15:53, <[email protected]> wrote: >>>>>> >>>>>>> Hi all, >>>>>>> >>>>>>> Following the directions from https://v8.dev/docs/contribute, I am >>>>>>> putting my first two patches (for review) for ARM64 that I would like >>>>>>> to >>>>>>> contribute to V8. >>>>>>> >>>>>>> First patch is a very simple patch - it adds default march for >>>>>>> ARM64. 64-bit support in ARM started with arm version 8. >>>>>>> Second patch is a probe implementation of ARM64, and probes for >>>>>>> crc32 feature. This feature is later used, if present, in hashing >>>>>>> algorithm. This patch improves speedometer performance by about half a >>>>>>> percent on current Samsung and Pixel devices. >>>>>>> >>>>>>> Please review these patches, and let me know what I need to do next >>>>>>> to get these patches committed. >>>>>>> >>>>>>> Sirish Pande >>>>>>> Samsung Austin R&D Center >>>>>>> >>>>>>> -- >>>>>>> -- >>>>>>> v8-dev mailing list >>>>>>> [email protected] >>>>>>> http://groups.google.com/group/v8-dev >>>>>>> --- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "v8-dev" group. >>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>> send an email to [email protected]. >>>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>>> >>>>>> -- >>>>> -- >>>>> v8-dev mailing list >>>>> [email protected] >>>>> http://groups.google.com/group/v8-dev >>>>> --- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "v8-dev" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> -- >>> -- >>> v8-dev mailing list >>> [email protected] >>> http://groups.google.com/group/v8-dev >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "v8-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
