I addressed the comments - could one of you have look at sqrt as well?
http://codereview.chromium.org/661179/diff/12/13 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/661179/diff/12/13#newcode5963 src/ia32/codegen-ia32.cc:5963: // allocate_return.Branch(not_equal); On 2010/03/03 15:08:09, Kevin Millikin wrote:
Commented code?
Done. http://codereview.chromium.org/661179/diff/12/13#newcode6046 src/ia32/codegen-ia32.cc:6046: Result res = frame_->CallRuntime(Runtime::kMath_pow, 2); On 2010/03/03 15:08:09, Kevin Millikin wrote:
Indentation is off here.
You might consider switching the sense of the conditional (!SSE
supported), so
the little case is at the top.
Done. http://codereview.chromium.org/661179 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
