LGTM.

http://codereview.chromium.org/661179/diff/3015/2013
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/661179/diff/3015/2013#newcode5918
src/ia32/codegen-ia32.cc:5918: Factory::heap_number_map());
Indentation? Ditto for other two.

http://codereview.chromium.org/661179/diff/3015/2013#newcode5919
src/ia32/codegen-ia32.cc:5919: call_runtime.Branch(not_zero);
not_zero->not_equal (I know they are identical, but for a comparison, it
reads much better)
Ditto for other two.

http://codereview.chromium.org/661179

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to