Just looking at squareroot: LGTM.
http://codereview.chromium.org/661179/diff/12/13 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/661179/diff/12/13#newcode6076 src/ia32/codegen-ia32.cc:6076: if (CpuFeatures::IsSupported(SSE2)) { You might want a x87-FPU version as well. I'm not sure whether we still create snapshots where SSE2 is not assumed. http://codereview.chromium.org/661179/diff/12/13#newcode6094 src/ia32/codegen-ia32.cc:6094: if (FLAG_debug_code) { You need to check that the argument is a HeapNumber every time, not just in debug mode. Arguments to runtime functions must be assumed to be potentially crafted by a malicious source. http://codereview.chromium.org/661179/diff/12/13#newcode6112 src/ia32/codegen-ia32.cc:6112: end.Jump(&result); Could you move this runtime call somewhere else, so that the fast path is just falling through, without any jumps. E.g., after the unconditional jump in line 6092. I'm not sure how that would interact with the virtual frame, though. http://codereview.chromium.org/661179 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
