http://codereview.chromium.org/668254/diff/1/2
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/668254/diff/1/2#newcode7210
src/x64/codegen-x64.cc:7210: ASSERT(kSmiTag == 0);
I think you can use JumpIfNotSmi from the x64 macro assembler here.

http://codereview.chromium.org/668254/diff/1/2#newcode8912
src/x64/codegen-x64.cc:8912: __ movq(Operand(rsp, rax_stack_offset),
rbx);
On 2010/03/08 11:43:19, Vyacheslav Egorov wrote:
As you can see I replaced frame creation and CallStub with
TailCallStub here.
But it required some strange code (see r*_stack_offset variables) and
I am not
sure whether it's worth it or not.

The best way to check whether it makes a difference is to measure the
difference.

http://codereview.chromium.org/668254

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to