Some additional comments.
http://codereview.chromium.org/668254/diff/1/2 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/668254/diff/1/2#newcode8861 src/x64/codegen-x64.cc:8861: int rax_stack_offset, rdx_stack_offset; I am not sure that finding the rax stack position is required. You will always have to replace the second argument which is at the top of the stack. http://codereview.chromium.org/668254/diff/1/2#newcode8868 src/x64/codegen-x64.cc:8868: rax_stack_offset = 2*kPointerSize; If you need this, please add spaces around *. http://codereview.chromium.org/668254/diff/1/2#newcode8906 src/x64/codegen-x64.cc:8906: // string for the smi in the number string cache. Is this correct? If HasArgsReversed() is true then the second argument is in rdx not rax. http://codereview.chromium.org/668254 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
