http://codereview.chromium.org/668254/diff/1/2 File src/x64/codegen-x64.cc (right):
http://codereview.chromium.org/668254/diff/1/2#newcode7210 src/x64/codegen-x64.cc:7210: ASSERT(kSmiTag == 0); On 2010/03/08 12:26:45, Søren Gjesse wrote:
I think you can use JumpIfNotSmi from the x64 macro assembler here.
Done. http://codereview.chromium.org/668254/diff/1/2#newcode8906 src/x64/codegen-x64.cc:8906: // string for the smi in the number string cache. On 2010/03/08 12:36:10, Søren Gjesse wrote:
Is this correct? If HasArgsReversed() is true then the second argument
is in rdx
not rax.
Indeed this comment (just like others in this case) is incorrect. I introduced lhs/rhs register aliases in attempt to make intent clean and fix contradiction between code and comments. http://codereview.chromium.org/668254 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
