LGTM
http://codereview.chromium.org/870007/diff/1/2 File src/ia32/stub-cache-ia32.cc (right): http://codereview.chromium.org/870007/diff/1/2#newcode1344 src/ia32/stub-cache-ia32.cc:1344: Immediate(Factory::fixed_array_map())); Indentation one space off? http://codereview.chromium.org/870007/diff/1/2#newcode1357 src/ia32/stub-cache-ia32.cc:1357: __ j(equal, &call_builtin, not_taken); I think it is fine to call the builtin in this case, but all you need to do is return undefined in that case, so it would be easy to handle here as well. Doing that, it seems we can remove the builtin once this is ported to the other platforms. http://codereview.chromium.org/870007 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
