Thanks a lot for comments, Lasse.
http://codereview.chromium.org/870007/diff/1/2 File src/ia32/stub-cache-ia32.cc (right): http://codereview.chromium.org/870007/diff/1/2#newcode1350 src/ia32/stub-cache-ia32.cc:1350: __ j(negative, &empty_array, not_taken); On 2010/03/12 12:31:37, Lasse Reichstein wrote:
not_taken is the default for forward jumps, but the implementation
still emits
the hint. Either remove the hint here (defaulting to no_hint) or change j(Condition,Label*,Hint) to not emit not_taken hints for forward jumps
and taken
hints for backwards jumps.
Fixed. I just wanted to be consistent with the rest of the code, but yes, I schedule my jumps that way :) Let me change ArrayPush impl as well. http://codereview.chromium.org/870007/diff/1/2#newcode1352 src/ia32/stub-cache-ia32.cc:1352: // Get the last element. On 2010/03/12 12:31:37, Lasse Reichstein wrote:
Ensure that using times_half_pointer_size turns a smi into a pointer
index,
e.g., STATIC_ASSERT(kSmiTagSize == 1); STATIC_ASSERT(kSmiTag == 0);
Done. http://codereview.chromium.org/870007/diff/1/2#newcode1357 src/ia32/stub-cache-ia32.cc:1357: __ j(equal, &call_builtin, not_taken); On 2010/03/12 12:31:37, Lasse Reichstein wrote:
Remove not_taken here too..
Sure. http://codereview.chromium.org/870007/diff/1/2#newcode1376 src/ia32/stub-cache-ia32.cc:1376: argc + 1, On 2010/03/12 12:31:37, Lasse Reichstein wrote:
Indentation.
Done. http://codereview.chromium.org/870007 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
