Thanks a lot for review, Mads. Doing stubs for other platforms and submitting.
http://codereview.chromium.org/870007/diff/1/2 File src/ia32/stub-cache-ia32.cc (right): http://codereview.chromium.org/870007/diff/1/2#newcode1344 src/ia32/stub-cache-ia32.cc:1344: Immediate(Factory::fixed_array_map())); On 2010/03/12 10:57:37, Mads Ager wrote:
Indentation one space off?
Done. http://codereview.chromium.org/870007/diff/1/2#newcode1357 src/ia32/stub-cache-ia32.cc:1357: __ j(equal, &call_builtin, not_taken); On 2010/03/12 10:57:37, Mads Ager wrote:
I think it is fine to call the builtin in this case, but all you need
to do is
return undefined in that case, so it would be easy to handle here as
well.
Doing that, it seems we can remove the builtin once this is ported to
the other
platforms.
(as discussed off-line): we need it still to fetch data from proto chain if present. http://codereview.chromium.org/870007 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
