http://codereview.chromium.org/2101002/diff/2001/3008 File src/heap-inl.h (right):
http://codereview.chromium.org/2101002/diff/2001/3008#newcode280 src/heap-inl.h:280: Object** src_object_p = reinterpret_cast<Object**>(src); On 2010/05/17 14:18:39, Mads Ager wrote:
I don't like the _p suffix. We are not using that naming convention
anywhere
else.
Well it was inherited from IterateRSetRange. I don't like suffix either but I think that name 'object' does not reflect variable meaning. I propose renaming to 'slot' or something similar. What do you think? http://codereview.chromium.org/2101002/diff/2001/3009 File src/heap.cc (right): http://codereview.chromium.org/2101002/diff/2001/3009#newcode3265 src/heap.cc:3265: ) { On 2010/05/17 14:18:39, Mads Ager wrote:
Indentation.
Strange that linter does not catch this style violation. I had to check style guide to understand how it should be indented. http://codereview.chromium.org/2101002/diff/2001/3010 File src/heap.h (right): http://codereview.chromium.org/2101002/diff/2001/3010#newcode757 src/heap.h:757: bool can_preallocate_during_iteration); On 2010/05/17 14:18:39, Mads Ager wrote:
Why is this called preallocate? Should it just be
can_allocate_during_iteration?
Also, would it make sense to have use an enum to get a meaningful name
to use at
callsites?
During scavenge allocation in old space and initialization of allocated space is separated in time. That is why I decided to call it 'preallocate'. I will try to find another meaningful name for it. http://codereview.chromium.org/2101002/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
