drive-by comments
http://codereview.chromium.org/2101002/diff/2001/3009 File src/heap.cc (right): http://codereview.chromium.org/2101002/diff/2001/3009#newcode3374 src/heap.cc:3374: Object** object_p = reinterpret_cast<Object**>(object_address); do not you want to assert that all the objects are now heap objects (here and in other verify functions)? http://codereview.chromium.org/2101002/diff/2001/3009#newcode3389 src/heap.cc:3389: return page + (((addr - page) + (Map::kSize - 1))/Map::kSize * Map::kSize); Map::kSize should be a power of two, no? Maybe use bit masking then? http://codereview.chromium.org/2101002/diff/2001/3018 File src/mark-compact.cc (right): http://codereview.chromium.org/2101002/diff/2001/3018#newcode1472 src/mark-compact.cc:1472: // Page::ClearRegionMarks(start, commented out? http://codereview.chromium.org/2101002/diff/2001/3027 File src/spaces.h (right): http://codereview.chromium.org/2101002/diff/2001/3027#newcode230 src/spaces.h:230: static const int kPageHeaderSize = kPointerSize + kPointerSize + kIntSize + do we want to check/ensure it is properly aligned? http://codereview.chromium.org/2101002/diff/2001/3029 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/2101002/diff/2001/3029#newcode4553 src/x64/codegen-x64.cc:4553: __ SmiToInteger32(rbx, rbx); now this part of code probably could be simplified---if I remember it correctly I needed two registers precisely for sometimes it is more convenient to work with smis and sometimes with ints. But I am not 100% sure. Could you file a bug and assign it to me when this CL is committed? http://codereview.chromium.org/2101002/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
