LGTM!
http://codereview.chromium.org/2101002/diff/26001/27005 File src/arm/macro-assembler-arm.h (right): http://codereview.chromium.org/2101002/diff/26001/27005#newcode117 src/arm/macro-assembler-arm.h:117: // For page containing |object| mark region covering [object+offset] dirty. page -> the page region -> the region http://codereview.chromium.org/2101002/diff/26001/27005#newcode120 src/arm/macro-assembler-arm.h:120: // For page containing |object| mark region covering [object+offset] dirty. page -> the page region -> the region http://codereview.chromium.org/2101002/diff/26001/27005#newcode121 src/arm/macro-assembler-arm.h:121: // Object address must be in the first 8K of an allocated page. The object address http://codereview.chromium.org/2101002/diff/26001/27006 File src/builtins.cc (right): http://codereview.chromium.org/2101002/diff/26001/27006#newcode308 src/builtins.cc:308: // region dirty marks. There is a mix of 'page dirty marks' and 'region dirty marks' in these comments. Choose one? http://codereview.chromium.org/2101002/diff/26001/27010 File src/heap.cc (right): http://codereview.chromium.org/2101002/diff/26001/27010#newcode823 src/heap.cc:823: // allocation to avoid overheads. So to maintain watermark invariant overheads -> overhead watermark invariant -> the watermark invariant http://codereview.chromium.org/2101002/diff/26001/27010#newcode824 src/heap.cc:824: // we have to manually cache watermark and mark page as having invalid the watermark the page an invalid http://codereview.chromium.org/2101002/diff/26001/27010#newcode3537 src/heap.cc:3537: region_end = region_start + Page::kRegionSize; Remove extra indentation. http://codereview.chromium.org/2101002/diff/26001/27010#newcode3547 src/heap.cc:3547: region_end = region_start + Page::kRegionSize; Ditto. http://codereview.chromium.org/2101002/diff/26001/27010#newcode3549 src/heap.cc:3549: mask <<= 1; Two spaces before <<= http://codereview.chromium.org/2101002/diff/26001/27011 File src/heap.h (right): http://codereview.chromium.org/2101002/diff/26001/27011#newcode1331 src/heap.h:1331: // Visitor class to verify interior pointers in spaces that does not contain does -> do http://codereview.chromium.org/2101002/diff/26001/27016 File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/2101002/diff/26001/27016#newcode132 src/ia32/macro-assembler-ia32.cc:132: // array access: calculate the destination address in the same manner as array -> Array http://codereview.chromium.org/2101002/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
