LGTM
http://codereview.chromium.org/2452002/diff/1/2 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/2452002/diff/1/2#newcode1228 src/arm/codegen-arm.cc:1228: new DeferredInlineSmiOperation(op, int_value, reversed, mode, tos); 4 space indent. http://codereview.chromium.org/2452002/diff/1/2#newcode1255 src/arm/codegen-arm.cc:1255: new DeferredInlineSmiOperation(op, int_value, true, mode, tos); 4 space indent. http://codereview.chromium.org/2452002/diff/1/2#newcode1271 src/arm/codegen-arm.cc:1271: } Maybe add an empty else block around this comment. http://codereview.chromium.org/2452002/diff/1/2#newcode1296 src/arm/codegen-arm.cc:1296: __ stop("smishift"); Test code (or never hit)? http://codereview.chromium.org/2452002/diff/1/6 File src/arm/virtual-frame-arm.cc (right): http://codereview.chromium.org/2452002/diff/1/6#newcode670 src/arm/virtual-frame-arm.cc:670: void VirtualFrame::SetElementAt(Register reg, int this_far_down) { No use for TypeInfo argument for this method? http://codereview.chromium.org/2452002/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
