http://codereview.chromium.org/2452002/diff/1/2 File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/2452002/diff/1/2#newcode1228 src/arm/codegen-arm.cc:1228: new DeferredInlineSmiOperation(op, int_value, reversed, mode, tos); On 2010/06/02 08:23:03, Søren Gjesse wrote:
4 space indent.
Done. http://codereview.chromium.org/2452002/diff/1/2#newcode1255 src/arm/codegen-arm.cc:1255: new DeferredInlineSmiOperation(op, int_value, true, mode, tos); On 2010/06/02 08:23:03, Søren Gjesse wrote:
4 space indent.
Done. http://codereview.chromium.org/2452002/diff/1/2#newcode1271 src/arm/codegen-arm.cc:1271: } On 2010/06/02 08:23:03, Søren Gjesse wrote:
Maybe add an empty else block around this comment.
Done. http://codereview.chromium.org/2452002/diff/1/2#newcode1296 src/arm/codegen-arm.cc:1296: __ stop("smishift"); On 2010/06/02 08:23:03, Søren Gjesse wrote:
Test code (or never hit)?
Paranoia code. Removed. http://codereview.chromium.org/2452002/diff/1/6 File src/arm/virtual-frame-arm.cc (right): http://codereview.chromium.org/2452002/diff/1/6#newcode670 src/arm/virtual-frame-arm.cc:670: void VirtualFrame::SetElementAt(Register reg, int this_far_down) { On 2010/06/02 08:23:03, Søren Gjesse wrote:
No use for TypeInfo argument for this method?
This method is almost never used for the expression stack, so it didn't seem worth it. http://codereview.chromium.org/2452002/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
