LGTM
http://codereview.chromium.org/2452002/diff/12001/13001 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/2452002/diff/12001/13001#newcode824 src/arm/codegen-arm.cc:824: void CodeGenerator::VirtualFrameBinaryOperation(Token::Value op, VirtualFrameBinaryOperation -> GenericBinaryOperation now it is the only one left? http://codereview.chromium.org/2452002/diff/12001/13001#newcode868 src/arm/codegen-arm.cc:868: Register lhs = frame_->PopToRegister(rhs); // Don't pop to rhs register. Long line. http://codereview.chromium.org/2452002/diff/12001/13001#newcode1148 src/arm/codegen-arm.cc:1148: VirtualFrameBinaryOperation(op, mode, GENERATE_INLINE_SMI, kUnknownIntValue); Long line. http://codereview.chromium.org/2452002/diff/12001/13001#newcode3497 src/arm/codegen-arm.cc:3497: if (literal != NULL) inline_smi = DONT_GENERATE_INLINE_SMI; Maybe assert !literal.IsSmi() when it is != NULL (more like this below). http://codereview.chromium.org/2452002/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
