Initial set of comments as discussed offline.
http://codereview.chromium.org/2566002/diff/3001/4001 File include/v8.h (right): http://codereview.chromium.org/2566002/diff/3001/4001#newcode2388 include/v8.h:2388: * Isolate represents an isolated instace of V8 engine. V8 isolates V8 engine -> V8 or V8 engine -> the V8 engine http://codereview.chromium.org/2566002/diff/3001/4001#newcode2390 include/v8.h:2390: * be used in other isolates. When V8 initializes a default isolate initializes -> is initialized? http://codereview.chromium.org/2566002/diff/3001/4001#newcode2392 include/v8.h:2392: * additional isolates and run them in parallel in multiple run them -> use them? http://codereview.chromium.org/2566002/diff/3001/4001#newcode2394 include/v8.h:2394: * given time. Locker/Unlocker API can be used to synchronize. Locker/Unlocker API -> The Locker/Unlocker API http://codereview.chromium.org/2566002/diff/3001/4001#newcode2421 include/v8.h:2421: static Isolate* New(); As discussed offline, we should have an explicit dispose method so we do not get into situations where memory allocated inside of V8 has to be deallocated outside of V8. If V8 is used as a shared library by code using a different allocator this could lead to trouble. http://codereview.chromium.org/2566002/diff/3001/4001#newcode2432 include/v8.h:2432: * restored by when exiting. Re-entering an isolate is allowed. by when -> when http://codereview.chromium.org/2566002/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
