Please take another look.
Thanks,
Vitaly
http://codereview.chromium.org/2566002/diff/3001/4001
File include/v8.h (right):
http://codereview.chromium.org/2566002/diff/3001/4001#newcode2388
include/v8.h:2388: * Isolate represents an isolated instace of V8
engine. V8 isolates
On 2010/06/03 14:05:46, Mads Ager wrote:
V8 engine -> V8 or V8 engine -> the V8 engine
Done.
http://codereview.chromium.org/2566002/diff/3001/4001#newcode2390
include/v8.h:2390: * be used in other isolates. When V8 initializes a
default isolate
On 2010/06/03 14:05:46, Mads Ager wrote:
initializes -> is initialized?
Done.
http://codereview.chromium.org/2566002/diff/3001/4001#newcode2392
include/v8.h:2392: * additional isolates and run them in parallel in
multiple
On 2010/06/03 14:05:46, Mads Ager wrote:
run them -> use them?
Done.
http://codereview.chromium.org/2566002/diff/3001/4001#newcode2394
include/v8.h:2394: * given time. Locker/Unlocker API can be used to
synchronize.
On 2010/06/03 14:05:46, Mads Ager wrote:
Locker/Unlocker API -> The Locker/Unlocker API
Done.
http://codereview.chromium.org/2566002/diff/3001/4001#newcode2421
include/v8.h:2421: static Isolate* New();
On 2010/06/03 14:05:46, Mads Ager wrote:
As discussed offline, we should have an explicit dispose method so we
do not get
into situations where memory allocated inside of V8 has to be
deallocated
outside of V8. If V8 is used as a shared library by code using a
different
allocator this could lead to trouble.
Done.
http://codereview.chromium.org/2566002/diff/3001/4001#newcode2432
include/v8.h:2432: * restored by when exiting. Re-entering an isolate
is allowed.
On 2010/06/03 14:05:46, Mads Ager wrote:
by when -> when
Done.
http://codereview.chromium.org/2566002/diff/3001/4001#newcode2448
include/v8.h:2448: Isolate& operator=(const Isolate&);
On 2010/06/03 12:49:40, Maxim.Mossienko wrote:
don't we need internal::Isolate* isolate_; as well as class
declaration in
namespace v8 { namespace internal { class Isolate; } } ?
Not really. We can reuse "this" pointer.
http://codereview.chromium.org/2566002/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
