http://codereview.chromium.org/2566002/diff/17001/18001
File include/v8.h (right):

http://codereview.chromium.org/2566002/diff/17001/18001#newcode2388
include/v8.h:2388: * Isolate represents an isolated instace of the V8
engine.  V8
typo: instace -> instance

http://codereview.chromium.org/2566002/diff/17001/18001#newcode2397
include/v8.h:2397: public:
I think that if we are to preserve API compatibility then many of V8
static methods should be instance ones in Isolate (e.g.
SetFatalErrorHandler, IsDead, SetCounterFunction, etc).
This would just reflect the fact of Isolate being instance of V8.

http://codereview.chromium.org/2566002/diff/17001/18001#newcode2433
include/v8.h:2433: * Methods below this point require holding a lock in
a
IMO bare 'lock' word is confusing in the description (given Locker class
existence), 'caller managed exclusive thread access' is better
description

http://codereview.chromium.org/2566002/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to