LGTM with a few nits.
http://codereview.chromium.org/2632003/diff/24001/25004 File src/heap.cc (right): http://codereview.chromium.org/2632003/diff/24001/25004#newcode2196 src/heap.cc:2196: for (StackFrameIterator it(top); !it.done(); it.Advance()) { We can bail out early if found_ is already true. http://codereview.chromium.org/2632003/diff/24001/25004#newcode2211 src/heap.cc:2211: void FlushCodeForFunction(SharedFunctionInfo* function_info) { nit: Missing "static". http://codereview.chromium.org/2632003/diff/24001/25004#newcode2220 src/heap.cc:2220: if (!function_info->code()->kind() == Code::FUNCTION) return; Does this prevent repeated flushing of a single shared function info that is reachable via several closures? http://codereview.chromium.org/2632003/diff/24001/25007 File src/objects.h (right): http://codereview.chromium.org/2632003/diff/24001/25007#newcode3309 src/objects.h:3309: inline bool allows_lazy_compilation(); This needs a comment. http://codereview.chromium.org/2632003/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
