Thanks for the additional comments Vitaly. I have addressed them and in addition I have added a small test case to test-heap.cc
http://codereview.chromium.org/2632003/diff/24001/25004 File src/heap.cc (right): http://codereview.chromium.org/2632003/diff/24001/25004#newcode2196 src/heap.cc:2196: for (StackFrameIterator it(top); !it.done(); it.Advance()) { On 2010/06/07 12:36:56, Vitaly wrote:
We can bail out early if found_ is already true.
Done. http://codereview.chromium.org/2632003/diff/24001/25004#newcode2211 src/heap.cc:2211: void FlushCodeForFunction(SharedFunctionInfo* function_info) { On 2010/06/07 12:36:56, Vitaly wrote:
nit: Missing "static".
Done. http://codereview.chromium.org/2632003/diff/24001/25004#newcode2220 src/heap.cc:2220: if (!function_info->code()->kind() == Code::FUNCTION) return; On 2010/06/07 12:36:56, Vitaly wrote:
Does this prevent repeated flushing of a single shared function info
that is
reachable via several closures?
This is actually already prevented by the is_compiled check earlier on (this will return false when we have flushed the code). http://codereview.chromium.org/2632003/diff/24001/25004#newcode2225 src/heap.cc:2225: // On 2010/06/07 12:25:36, Mads Ager wrote:
Complete comment?
Done. http://codereview.chromium.org/2632003/diff/24001/25004#newcode2228 src/heap.cc:2228: // If this function is in the compilation cache we flush the code. On 2010/06/07 12:25:36, Mads Ager wrote:
we flush -> we do not flush
Done. http://codereview.chromium.org/2632003/diff/24001/25007 File src/objects.h (right): http://codereview.chromium.org/2632003/diff/24001/25007#newcode3309 src/objects.h:3309: inline bool allows_lazy_compilation(); On 2010/06/07 12:36:56, Vitaly wrote:
This needs a comment.
Done. http://codereview.chromium.org/2632003/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
