http://codereview.chromium.org/2632003/diff/9001/10001 File src/compilation-cache.cc (right):
http://codereview.chromium.org/2632003/diff/9001/10001#newcode219 src/compilation-cache.cc:219: CompilationCacheTable::cast(tables_[generation]); Four-space indent. http://codereview.chromium.org/2632003/diff/9001/10001#newcode221 src/compilation-cache.cc:221: Object* object = table->Lookup(String::cast(script->source())); Extract the source before the loop? http://codereview.chromium.org/2632003/diff/9001/10002 File src/compilation-cache.h (right): http://codereview.chromium.org/2632003/diff/9001/10002#newcode83 src/compilation-cache.h:83: static bool HasFunction(SharedFunctionInfo* sfi); I like function_info better than sfi. http://codereview.chromium.org/2632003/diff/9001/10004 File src/heap.cc (right): http://codereview.chromium.org/2632003/diff/9001/10004#newcode2190 src/heap.cc:2190: // the code contains the stack pointer from any of the stacks. It is the other way around: to see if there are activations on any of the stack corresponding to the code. http://codereview.chromium.org/2632003/diff/9001/10004#newcode2211 src/heap.cc:2211: void FlushFunction(SharedFunctionInfo* sfi) { FlushFunction -> FlushCodeForFunction? http://codereview.chromium.org/2632003/diff/9001/10004#newcode2216 src/heap.cc:2216: // We never delete Api functions. delete -> flush code for http://codereview.chromium.org/2632003/diff/9001/10004#newcode2219 src/heap.cc:2219: // This must be a function type. Only flush code for functions. http://codereview.chromium.org/2632003/diff/9001/10004#newcode2225 src/heap.cc:2225: // If this function is in the compilation cache we don't remove it. don't remove it -> do not flush the code. http://codereview.chromium.org/2632003/diff/9001/10004#newcode2245 src/heap.cc:2245: // Do not flush code if debug is loaded. debug is loaded -> the debugger is loaded? http://codereview.chromium.org/2632003/diff/9001/10004#newcode2251 src/heap.cc:2251: // Don't remove unnamed functions. I don't think I understand why we cannot flush the code for anonymous functions? Could you explain why or allow it? :) http://codereview.chromium.org/2632003/diff/9001/10005 File src/heap.h (right): http://codereview.chromium.org/2632003/diff/9001/10005#newcode1269 src/heap.h:1269: static void FlushCode(); Please add a comment. http://codereview.chromium.org/2632003/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
