On 2010/06/19 10:25:08, Maxim.Mossienko wrote:
several drive by comments for increasing code clarity
http://codereview.chromium.org/2836017/diff/5002/12006
File src/mark-compact.cc (right):
http://codereview.chromium.org/2836017/diff/5002/12006#newcode269
src/mark-compact.cc:269: HEAP->mark_compact_collector()->MarkObject(code);
please make heap_ instance in MarkingVisitor
http://codereview.chromium.org/2836017/diff/5002/12009
File src/spaces.cc (right):
http://codereview.chromium.org/2836017/diff/5002/12009#newcode732
src/spaces.cc:732: first_page_ =
Isolate::Current()->memory_allocator()->CommitPages(
Please, add protected isolate_ instance member in Space class, it will
make
code
cleaner in all descendants
http://codereview.chromium.org/2836017/diff/5002/12012
File test/cctest/test-spaces.cc (right):
http://codereview.chromium.org/2836017/diff/5002/12012#newcode94
test/cctest/test-spaces.cc:94:
CHECK(Isolate::Current()->memory_allocator()->Setup(HEAP->MaxReserved()));
please introduce local variable for Isolate::Current()->memory_allocator()
The first two changes I'm holding off on until the statics are all
converted (it
might be better to add heap_ into ObjectVisitor itself-- I started out this
CL
this way-- but such changes don't belong so much in these generally
search/replace jobs).
http://codereview.chromium.org/2836017/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
