One more presubmit.py problem
mark-compact.cc:42: Labels should always be indented at least one space.
If
this is a member-initializer list in a constructor, the colon should be on
the
line after the definition header. [whitespace/labels] [4]
On 2010/06/21 22:48:00, zarko wrote:
Thanks for the comments!
http://codereview.chromium.org/2836017/diff/29002/34007
File src/mark-compact.h (right):
http://codereview.chromium.org/2836017/diff/29002/34007#newcode59
src/mark-compact.h:59: void Initialize(Address low, Address high) {
On 2010/06/21 22:25:01, Vitaly wrote:
> Can't we turn this function into a constructor?
It doesn't seem to be used in a way that would make this simple.
http://codereview.chromium.org/2836017/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
