LGTM
http://codereview.chromium.org/2836017/diff/29002/34004 File src/isolate.cc (right): http://codereview.chromium.org/2836017/diff/29002/34004#newcode253 src/isolate.cc:253: sizeof(code_kind_statistics_[0]) * Code::NUMBER_OF_KINDS); nit: Align to line up with "code_...". http://codereview.chromium.org/2836017/diff/29002/34007 File src/mark-compact.h (right): http://codereview.chromium.org/2836017/diff/29002/34007#newcode59 src/mark-compact.h:59: void Initialize(Address low, Address high) { Can't we turn this function into a constructor? http://codereview.chromium.org/2836017/diff/29002/34007#newcode65 src/mark-compact.h:65: bool is_full() { return top_ >= high_; } These three accessors should be "const". http://codereview.chromium.org/2836017/diff/29002/34007#newcode98 src/mark-compact.h:98: }; Missing DISALLOW_COPY_AND_ASSIGN. http://codereview.chromium.org/2836017/diff/29002/34007#newcode455 src/mark-compact.h:455: void ScanOverflowedObjects(T* it); I'm not sure all compilers are going to be happy about this. Can we keep the template in the .cc file? http://codereview.chromium.org/2836017/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
